Skip to content

Add Salesio hosting template (salesio.app/hosting)#998

Open
zoilagr wants to merge 3 commits intoDomain-Connect:masterfrom
zoilagr:add-salesio-hosting-template
Open

Add Salesio hosting template (salesio.app/hosting)#998
zoilagr wants to merge 3 commits intoDomain-Connect:masterfrom
zoilagr:add-salesio-hosting-template

Conversation

@zoilagr
Copy link
Copy Markdown

@zoilagr zoilagr commented Apr 15, 2026 •
edited
Loading

Description

Adds a new Domain Connect template for Salesio (salesio.app) that points a user's apex domain and www subdomain to Salesio hosting. This allows users to connect their custom domains to their Salesio landing pages automatically via Domain Connect.

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json → salesio.app.hosting.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

  • syncPubKeyDomain is set
  • warnPhishing is not set alongside syncPubKeyDomain
  • syncRedirectDomain is set (single domain as required)
  • no TXT record contains SPF content (no TXT records in this template)
  • txtConflictMatchingMode not needed (no TXT records)
  • no variable is used as a bare full record value
  • no bare variable is used as the full host label
  • no variable is used in the host field to create a subdomain
  • %host% does not appear explicitly in any host attribute
  • essential is set where applicable (no essential fields required for this template)

Online Editor test results

Editor test link(s):

@github-actions github-actions bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026 •
edited
Loading

✅ JSON Filename Check Passed

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026 •
edited
Loading

✅ JSON Schema Validation Passed

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026 •
edited
Loading

Linter OK

salesio.app.hosting.json

Level Code Note

@github-actions github-actions bot removed Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Apr 15, 2026
pawel-kow
pawel-kow requested changes Apr 15, 2026
View reviewed changes
Comment thread salesio.app.hosting.json Outdated
"serviceId": "hosting",
"serviceName": "Salesio Landing Page Hosting",
"syncPubKeyDomain": "salesio.app",
"syncRedirectDomain": "salesio.app, webapp.salesio.app",
Copy link
Copy Markdown
Member

@pawel-kow pawel-kow Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see and fix linter warning

@github-actions github-actions bot added Test links missing No test links from Online Editor provided and removed Test links missing No test links from Online Editor provided labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

PR Description Check Passed

All required sections are filled in correctly.

Details 
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 2 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@pawel-kow pawel-kow enabled auto-merge April 15, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawel-kow pawel-kow pawel-kow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoilagr @pawel-kow